GCS_MAVLink: don't learn a route to the broadcast component #14620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
force-pushed
the
pr/no-route-component
branch
from
d85ea22
to
6065c72
Compare
Using a component ID of 0 for your source is invalid according to common.xml However, some clients do use it. This stops us learning a route to that client for the broadcast client for our own system ID.
.... even if we've forwarded them to someone else.
peterbarker
force-pushed
the
pr/no-route-component
branch
from
6065c72
to
3b833a1
Compare
|
This PR fixes dataflash-over-mavlink on CubeOrange. The second patch here was required as currently we don't process messages sent to the broadcast system if we've forwarded to any other system - which is wrong. It means if you connect a second GCS on a second telemetry link then we stop processing |
| } | ||
| if (msg.sysid == mavlink_system.sysid && | ||
| msg.compid == mavlink_system.compid) { | ||
| // don't learn routes to ourself. We know where we are. |
There was a problem hiding this comment.
it would be funnier with "We know who we are" :)
lucasdemarchi
approved these changes
Oct 13, 2020
|
Marking this as DevCall in case @lucasdemarchi (owner) doesn't merge it before then :-) |
tridge
approved these changes
Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a component ID of 0 for your source is invalid according to
common.xml
However, some clients do use it.
This stops us learning a route to that client for the broadcast client
for our own system ID.